https://bugzilla.redhat.com/show_bug.cgi?id=1813687 --- Comment #8 from Nikola Forró <nforro@xxxxxxxxxx> --- A couple of notes: - version-release in %changelog doesn't match Version and Release - release number shouldn't be 0 - use %global instead of %define - consider using %configure, %make_build and %make_install macros - there is a COPYING license file, it should be installed and marked with %license - Copyright should be probably marked with %license too - how did you come up with "MIT and BSD" license? the package seems to be distributed under LGPLv2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
