https://bugzilla.redhat.com/show_bug.cgi?id=1812411 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Artur Iwicki from comment #1) > >License: GPL-3 > The proper identifier in Fedora is "GPLv3". > https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses > > Also, from upstream's meson.build: > ># project name and programming language > >project('com.github.babluboy.bookworm', ['vala', 'c'], > > version: '1.1.2' > >) > I'm not sure if using the full name is a good idea here, since if you look > into your built package, you'll see that the executable that's put in > /usr/bin ends up called "com.github.babluboy.bookworm". While many packages > in Fedora use reverse-domain-name full names for .desktop and .appdata.xml > files, I'm not sure if any do that for the binaries and /usr/share stuff. > Maybe someone more knowledgeable about the subject could share their opinion. This is the way all "made for elementary" / appcenter applications are set up. It's a bit unusual to also use the RDNN name for the executable, but since it works and the application is expected to be launched from a launcher anyway, it's not a problem. You can look at other elementary applications for examles of this. (That doesn't mean I agree with them on this decision - I'd much rather have an executable be named elementary-music instead of io.elementary.music, but that's upstream's decision, in the end. At least they have consistent guidelines for this stuff.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
