[Bug 1806017] Review Request: opae - a sdk for fpga hardware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1806017



--- Comment #9 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> ---
Please see the definition of %make_build, and the entry in the Guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make There
is no need to add %{?_smp_mflags} to the invocation.

Additionally, this:

cd _build
make DESTDIR=%{buildroot} install

can be shortened to:

%make_install -C _build

Also, you have %license somewhere in the middle of the spec file. It does not
belong there, and is just putting random text at the end of your %description.
%license is a marker for entries in %files, like %doc or %dir, so the two
entries in %files should be changed from %doc to %license.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux