https://bugzilla.redhat.com/show_bug.cgi?id=1806017 --- Comment #8 from Neil Horman <nhorman@xxxxxxxxxx> --- The review looks good now, but I'm confused about the _smp_mflags issue. I understand that your local builds reduce _smp_mflags to the same string, but theres no guarantee of that when doing official builds in fedora. Different buildroots will set those flags to different strings, and many are non-default to the local setup (they enable hardening, etc). That needs to be returned to the spec file, please Other than that though, it looks good. I'm not worried about the out of tree patches. For user space packages, since you are the maintainer currently, its your prerogative to decide whats ok to carry and whats not. If you're ok with those patches, and they're open source licensed, its fine with me. if you can readd the _smp_mflags macro, I'll approve this immediately. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
