https://bugzilla.redhat.com/show_bug.cgi?id=1801533 --- Comment #5 from Kairui Song <kasong@xxxxxxxxxx> --- (In reply to Attila Lakatos from comment #4) > 1. It is not a MUST thing but you should consider to add a man page for > memstrack binary file. If you do not have one, work with upstream to add one > where it makes sense. However, it's only up to you. Thanks, I'll consider it in the furture, and there is a README should have a brief introduction to the tool and the TUI is already inteactive and provide basic usage info. > > > install -p -m 644 misc/99memstrack/module-setup.sh %{buildroot}/%{dracutmoduledir}/module-setup.sh > 2. memstrack.spec:49: Are you sure that you want to set the file permissions > to 644? In that case it creates a non-executable script. That's right, that's a dracut module which don't need execution permission. > > 3. No owner of /usr/lib/dracut/module.d > Your package should own all of the files that are installed as part of the > %install process. Good catch, will fix it. That's a malformed dracut module path, this package don't own it, so I should just install files under it and dont touch the dir itself, and add dependency on dracut to ensure it exists. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
