https://bugzilla.redhat.com/show_bug.cgi?id=1801533 Attila Lakatos <alakatos@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alakatos@xxxxxxxxxx Flags| |needinfo?(kasong@xxxxxxxxxx | |) --- Comment #4 from Attila Lakatos <alakatos@xxxxxxxxxx> --- 1. It is not a MUST thing but you should consider to add a man page for memstrack binary file. If you do not have one, work with upstream to add one where it makes sense. However, it's only up to you. > install -p -m 644 misc/99memstrack/module-setup.sh %{buildroot}/%{dracutmoduledir}/module-setup.sh 2. memstrack.spec:49: Are you sure that you want to set the file permissions to 644? In that case it creates a non-executable script. 3. No owner of /usr/lib/dracut/module.d Your package should own all of the files that are installed as part of the %install process. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
