[Bug 1803479] Review Request: libredwg-0.10.1 - new package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1803479

Artur Iwicki <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx



--- Comment #3 from Artur Iwicki <fedora@xxxxxxxxxx> ---
>%install
>rm -rf $RPM_BUILD_ROOT
Don't do this.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

>%{_mandir}/man1/dwg2SVG.1.gz
>...
>%{_mandir}/man1/dxf2dwg.1.gz
Do not assume that man pages will be gzipped. Use a wildcard that can match
both compressed and non-compressed files.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages

>%make_build PERL=/usr/bin/perl PYTHON=/usr/bin/python
1. I'd recommend using %{_bindir} here instead of specifying /usr/bin as a raw
string.
2. Fedora Packages are disallowed from using "python"; you must explicitly use
"python3".
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes

>%package -n     python3-LibreDWG
>Requires:       %{name}%{?_isa} = %{version}-%{release}, python
1. I'd split this into two separate "Requires:" lines for readability.
2. You should require "python3", not just "python".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux