[Bug 1806386] Re-review Request: pnmixer - Lightweight mixer applet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1806386

Artur Iwicki <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Artur Iwicki <fedora@xxxxxxxxxx> ---
>Group:          Applications/Multimedia
The "Group:" tag is not used in Fedora.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

>URL:            https://github.com/nicklan/pnmixer
>Source0:        %{url}/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
For GitHub, you can use "archive/v%{version}/%{name}-%{version}.tar.gz".

># Fix icon in launcher
>sed -i \
>    's/Icon=pnmixer/Icon=multimedia-volume-control/' \
>    data/desktop/pnmixer.desktop.in
>[...]
>%files
>%{_datadir}/icons/hicolor/128x128/apps/%{name}.png
If the program comes with an icon, why replace it in the desktop file? Could
you perhaps expand the comment?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux