https://bugzilla.redhat.com/show_bug.cgi?id=1802803 --- Comment #4 from Omair Majid <omajid@xxxxxxxxxx> --- (In reply to Michael Cronenworth from comment #3) > I've performed an initial review and found the following issues. Thanks! > - /usr/lib64/dotnet is not owned. This package should own it if the package > 'dotnet-build-reference-packages' is not required. If > 'dotnet-build-reference-packages' is required then add a Requires: > dotnet-build-reference-packages instead. `dotnet-build-reference-packages` is a build-time-only dependency, so `/usr/lib64/dotnet` should be owned by some package/subpackage here. The spec file contains: %files -n dotnet-host %dir %{_libdir}/dotnet And dotnet-host needs to be installed for any other subpackage in this package to be installed. Can you help me figure out what other subpackage needs to own /usr/lib64/dotnet? > - nethost.h is installed. Is it required for the runtime to run? It should > go into a -devel subpackage, ideally. Supposedly, it's part of the runtime, since it is placed under `/usr/lib64/dotnet/shared/`, and `shared` is just a short form of "Shared Framework" aka "Runtime". I dont think the runtime itself requires it. It sounds like this is a way to host the .NET Core runtime (https://docs.microsoft.com/en-us/dotnet/core/tutorials/netcore-hosting) in a native application. If this is the only file, does it still make sense to put it in a separate -devel package? > - > /usr/lib64/dotnet/shared/Microsoft.NETCore.App/3.1.1/System.Security. > Cryptography.Native.OpenSsl.a - is this static library necessary for the > runtime to run? It needs to either be removed or go into a -static > subpackage if it is not necessary. This is a bit complicated and even upstream doesn't have a very good handle on it: https://github.com/dotnet/runtime/issues/3447. As I understand it, some types of .NET applications require (or will require) the static libraries (at build-time?). Perhaps I should create a dotnet-runtime-3.1-devel subpackage and put the .h and .a files in it? I wonder what impact that might have if the files are not present and the user tries to build applications... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
