https://bugzilla.redhat.com/show_bug.cgi?id=1801013 Bug ID: 1801013 Summary: Review Request: date - Date and time library based on the C++11/14/17 <chrono> header Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: alebastr89@xxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/alebastr/waybar/fedora-rawhide-x86_64/01233939-date/date.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/waybar/fedora-rawhide-x86_64/01233939-date/date-2.4.1-1.20200207git9a0ee25.fc32.src.rpm Description: Date and time library based on the C++11/14/17 <chrono> header. This is actually several separate libraries: - "date.h" is a header-only library which builds upon <chrono>. It adds some new duration types, and new time_point types. It also adds "field" types such as year_month_day which is a struct {year, month, day}. And it provides convenient means to convert between the "field" types and the time_point types. - "tz.h" / "tz.cpp" are a timezone library built on top of the "date.h" library. This timezone library is a complete parser of the IANA timezone database. It provides for an easy way to access all of the data in this database, using the types from "date.h" and <chrono>. The IANA database also includes data on leap seconds, and this library provides utilities to compute with that information as well. <...> (see spec or upstream github for a full description) Slightly modified versions of "date.h" and "tz.h" were voted into the C++20 working draft. Fedora Account System Username: alebastr Q/A section: - Why do I want to package this? New version of waybar will depend on timezone library. The alternative would be bundling the library with waybar which I want to avoid. - Why is the name so generic? It's upstream project name. It's worth noting that the project installs headers under /usr/include/date and ships cmake and pkgconfig modules under the same name. Any renaming should be carefully considered. - Why am I packaging git snapshot? Last released version is 2 years old and contains only rudimentary CMake support. Extracting patch with only CMake changes is unfeasible due to the amount of such changes. Also, upstream author recommends to use master branch instead of latest release: https://github.com/HowardHinnant/date/issues/533. - Why certain test sources are deleted in the spec? The upstream's test suite does not support excluding specific tests. It looks for files matching specific patterns, compiles and runs all of them. One of the tests I removed would always fail with gcc. The other one could fail in mock builder due to incorrect timezone configuration within the chroot. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
