https://bugzilla.redhat.com/show_bug.cgi?id=1339227 --- Comment #10 from kusumi.tomohiro@xxxxxxxxx --- Thanks for your comments. Updated spec file and SRPM are available at below. https://leaf.dragonflybsd.org/~tkusumi/rpms/fedora31_v2/ > - Not needed, if thebuild is not set as noarch then it is arched by default: > > # fileobj contains C extension > BuildArch: x86_64 Removed BuildArch. > > > - Glob the man page extension as the compression may change in the future: > > %{_mandir}/man1/%{srcname}.1.* Glob'd the man page. > > - Source is 404: > > Source0: %{pypi_source} > > You don't seem to have published it on Pypi: https://pypi.org/search/?q=fileobj > > Use Github then: > > Source0: %url/archive/v%{version}/%{name}-%{version}.tar.gz Changed it to a GitHub URL. > > - Since it is a binary package, I think you should just name it fileobj and not provide a python3 subpackage. > > Name: fileobj > > […] > > %files > %license COPYING > %doc CHANGES CONTRIBUTORS PKG-INFO README.md RELEASES > %{python3_sitearch}/%{srcname}-*.egg-info > %{python3_sitearch}/%{srcname}/ > %{_bindir}/%{srcname} > %{_mandir}/man1/%{srcname}.1.* Changed it to "fileobj" package. Also removed %python_provide macro part for python3- package based on what's mentioned in below. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides > > - You need to BR gcc as well: > > BuildRequires: python3-devel > BuildRequires: gcc Added gcc. > > - PKG-INFO is not found, don't include it > > RPM build errors: > File not found: /builddir/build/BUILDROOT/fileobj-0.7.94-1.fc32.x86_64/usr/share/doc/fileobj/PKG-INFO Removed PKG-INFO. Looks like a tarball from GitHub doesn't contain PKG-INFO, while sdist'd tarball from upstream source does contain PKG-INFO, and my SRPM previously contained sdist'd tarball. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
