[Bug 1785069] Review request: lector -- ebook reader and collection manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1785069



--- Comment #8 from Andrew Toskin <andrew@xxxxxxx> ---
Updated package spec.

Spec URL:
https://gitlab.com/terrycloth/packaging-lector/uploads/751796450ddf418b29a2b548b7b65c15/lector.spec

SRPM URL:
https://gitlab.com/terrycloth/packaging-lector/uploads/85ed14ac37eeb2cdd85a20058ed8627a/lector-0.5.1-1.fc32.src.rpm


...You'll notice some small changes to the dependencies again. In Bug #1785073,
I learned that python-markdown can't be backported for Fedora 30 without making
backward-incompatible changes or breaks to other f30 packages. The maintainer
for python-lxml hasn't said anything yet in Bug #1784998, but I'm guessing now
that it wasn't backported to f30 for similar reasons. So I've decided to focus
on f31+ after all.

RPM Lint output looks good to me now, though there are maybe a few remaining
issues that I'm unsure about. When running fedora-review, I see a lot of lines
like this in the terminal output:

  Last metadata expiration check: 0:02:06 ago on Mon Jan 13 14:50:39 2020.
  Failed to set locale, defaulting to C.UTF-8
  Failed to set locale, defaulting to C.UTF-8
  Last metadata expiration check: 0:02:09 ago on Mon Jan 13 14:50:39 2020.
  Failed to set locale, defaulting to C.UTF-8
  Failed to set locale, defaulting to C.UTF-8
  Failed to set locale, defaulting to C.UTF-8

Not sure if that's something I should worry about or not, if localizations are
already compiled and they don't get to get find_lang'd or whatever, like we'd
discussed.

fedora-review.txt also includes an Installation Errors section:

  Installation errors
  -------------------
  INFO: mock.py version 1.4.21 starting (python version = 3.7.5)...
  Start: init plugins
  INFO: selinux enabled
  Finish: init plugins
  INFO: Signal handler active
  Start: run
  Start: chroot init
  INFO: calling preinit hooks
  INFO: enabled root cache
  INFO: enabled dnf cache
  Start: cleaning dnf metadata
  Finish: cleaning dnf metadata
  INFO: enabled HW Info plugin
  Mock Version: 1.4.21
  INFO: Mock Version: 1.4.21
  Finish: chroot init
  INFO: installing package(s):
/home/terrycloth/creating/packaging/Lector/review-lector/results/lector-0.5.1-1.fc32.noarch.rpm
  ERROR: Command failed: 
   # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/
--releasever 32 --setopt=deltarpm=False --allowerasing --disableplugin=local
--disableplugin=spacewalk install
/home/terrycloth/creating/packaging/Lector/review-lector/results/lector-0.5.1-1.fc32.noarch.rpm
--setopt=tsflags=nocontexts

...Even though ./review-lector/results/build.log shows no errors. Not sure yet
what this means either.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux