[Bug 1785069] Review request: lector -- ebook reader and collection manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1785069



--- Comment #7 from Andrew Toskin <andrew@xxxxxxx> ---
(In reply to Michael Schwendt from comment #5)
> The reason is simple. No translation files get installed into the buildroot
> [yet]. %find_lang --with-qt would search for Qt's compiled translation files
> *.qm, which are created with the lrelease tool from Qt Linguist (package
> qt5-linguist).

I'm not really sure what you're trying to say here. Sounds like maybe you're
saying I need to BuildRequire qt5-linguist, and run lrelease at some point in
the script?

Or maybe not, since Robert says:

(In reply to Robert-André Mauchin from comment #6)
>  The translations are compiled into a resources file, no need to find_lang
> them indeed. But I didn't manage to get Lector launched into another
> language.

Funny, when I thought to actually just try changing the language with no
%find_lang at all, Lector successfully changed to Spanish when I changed my
system language to Spanish. Maybe it's not the packaging that's the problem,
just the source translations are slightly broken or incomplete? I asked
upstream about this here -- https://github.com/BasioMeusPuga/Lector/issues/117

...I've sent upstream a pull request for the AppStream metainfo.xml file. Feel
free to take a look there in case I missed or messed up something.

  https://github.com/BasioMeusPuga/Lector/pull/120

I'll take another look at the issues flagged by rpmlint and then have another
updated spec for you soon. Thanks again, both of you, for your continued help
:)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux