https://bugzilla.redhat.com/show_bug.cgi?id=1768027 --- Comment #7 from Marcus Müller <marcus@xxxxxxxxxxx> --- > Remove the code in %prep Removed! Didn't expect it to work without. > > [x]: %build honors applicable compiler flags or justifies otherwise. > > Are you sure that flags are used? > > `%make_build CFLAGS=-g` is fundamentally wrong I feel the same, but: without `-g`, there's no debug symbols to be extracted, and rpmbuilding fails. It took me a while to figure out that supplying `-g` helps. ``` + /usr/lib/rpm/find-debuginfo.sh -j8 --strict-build-id -m -i --build-id-seed 27-1.fc29 --unique-debug-suffix -27-1.fc29.x86_64 --unique-debug-src-base signify-27-1.fc29.x86_64 --run-dwz --dwz-low-mem-die-limit 10000000 --dwz-max-die-limit 110000000 -S debugsourcefiles.list /home/marcus/src/signify-package/signify-27 explicitly decompress any DWARF compressed ELF sections in /home/marcus/rpmbuild/BUILDROOT/signify-27-1.fc29.x86_64/usr/bin/signify extracting debug info from /home/marcus/rpmbuild/BUILDROOT/signify-27-1.fc29.x86_64/usr/bin/signify gdb-add-index: No index was created for /home/marcus/rpmbuild/BUILDROOT/signify-27-1.fc29.x86_64/usr/bin/signify gdb-add-index: [Was there no debuginfo? Was there already an index?] /usr/lib/rpm/sepdebugcrcfix: Updated 0 CRC32s, 1 CRC32s did match. […] Processing files: signify-debugsource-27-1.fc29.x86_64 error: Empty %files file /home/marcus/src/signify-package/signify-27/debugsourcefiles.list Empty %files file /home/marcus/src/signify-package/signify-27/debugsourcefiles.list ``` With `-g`, the debug symbols get extracted, then the binary gets stripped and a stripped binary gets installed: ``` $ file $(which signify) /usr/bin/signify: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=e481012b03a1ccefe987d294d18eafc9f4b49935, stripped ``` Which led me to believe this was the right way to go. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
