[Bug 1768027] Review Request: signify - Sign and encrypt files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1768027

Antonio <anto.trande@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anto.trande@xxxxxxxxx



--- Comment #6 from Antonio <anto.trande@xxxxxxxxx> ---
(In reply to Marcus Müller from comment #5)
> (In reply to Marcus Müller from comment #3)
> 
> to be specific:
> 
> > libwaive is included in the upstream source, but not being used (unless you
> > `make PLEDGE=waive`, which I don't), so no action required.
> 
> It's not being compiled, and not installed as library, either, so I really
> can't claim anything provides this.

Remove the code in %prep

> [x]: %build honors applicable compiler flags or justifies otherwise.

Are you sure that flags are used?

`%make_build CFLAGS=-g` is fundamentally wrong

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux