[Bug 1768027] Review Request: signify - Sign and encrypt files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1768027



--- Comment #4 from Marcus Müller <marcus@xxxxxxxxxxx> ---
(In reply to Ondřej Pohořelský from comment #1)
> This is informal review only. Feedback appreciated.


Feedback: thank you! Very much appreciated.

> I would advise you to contact upstream regarding license file. 

Done! https://github.com/aperezdc/signify/pull/24

> Also it would
> be nice to have %check and tests.

On it. As soon as
https://github.com/aperezdc/signify/commit/b82aa79bd2d679a31efd53f4eddcea5e56bf2ceb
is part of a release, will include %check

> [!]: License file installed when any subpackage combination is installed.

As soon as https://github.com/aperezdc/signify/pull/24 is part of a release,
this will be done.

> ===== SHOULD items =====
> Generic:
> [?]: If the source package does not include license text(s) as a separate
>      file from upstream, the packager SHOULD query upstream to include it.

in process, see above

> [?]: Package functions as described.

Fundamental truth: Software is buggy, but this is relatively fine.

> [!]: %check is present and all tests pass.

in process, see above

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux