https://bugzilla.redhat.com/show_bug.cgi?id=1768027 --- Comment #3 from Marcus Müller <marcus@xxxxxxxxxxx> --- (In reply to Vít Ondruch from comment #2) > * Wrong use of PREFIX in install section > - Usage of '/usr' is definitely not right. If nothing else, there should > be used %{_prefix} macro for this purpose Fixing that. > - I have not looked into the project, but wouldn't be better to override > the DESTDIR? fails when setting DESTDIR, works with PREFIX > * Bundled libwaive > - It appears that at leas in upstream repository, there is bundled > libwaive. Would it be possible to unbundle this library? If not, there > should be bundled provide [1] in .spec file mentioning this library. libwaive is included in the upstream source, but not being used (unless you `make PLEDGE=waive`, which I don't), so no action required. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
