https://bugzilla.redhat.com/show_bug.cgi?id=1787618 --- Comment #4 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Guido Aulisi from comment #3) > This is an informal preliminary review: > Thanks. > > > BuildRequires: gcc, make, automake, libtool > > BuildRequires: glib2-devel, gtk2-devel, SDL-devel, libpng-devel, libftdi-devel > Please list one require per line, it's really more readable > NP, fixed. > > Patch0: libzia-4.18-soname-fix.patch > Please document this patch, and if possible talk to upstream to use correct > soname > Comment added: # This is to fulfill Fedora requirement - it marks the interface with # version number 0. Upstream uses --release versioning in libtool. # They do not support linking between different versions of tucnak and # libzia, i.e. tucnak-4.18 needs to be linked to libzia-4.18. > Devel package should require main package: > Requires: %{name}%{?_isa} = %{version}-%{release} > Fixed. > > %setup -q > > %patch0 -p1 -b .soname-fix > You could use > %autosetup -p1 > I know, but I prefer this form - it's better when e.g. rebasing multiple patches. > > %ldconfig_scriptlets > I think it's not needed in all supported Fedora releases > I think you are right - no EPEL-7 intended at the moment - dropped. > > %files > > ... > > %{_libdir}/libzia-%{version}.so.* > According to [0], it's better to glob shared libraries this way: > %{_libdir}/libzia-%{version}.so.0* > Fixed. New version: Spec URL: https://jskarvad.fedorapeople.org/libzia/libzia.spec SRPM URL: https://jskarvad.fedorapeople.org/libzia/libzia-4.18-2.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
