https://bugzilla.redhat.com/show_bug.cgi?id=1787618 Guido Aulisi <guido.aulisi@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |guido.aulisi@xxxxxxxxx --- Comment #3 from Guido Aulisi <guido.aulisi@xxxxxxxxx> --- This is an informal preliminary review: > BuildRequires: gcc, make, automake, libtool > BuildRequires: glib2-devel, gtk2-devel, SDL-devel, libpng-devel, libftdi-devel Please list one require per line, it's really more readable > Patch0: libzia-4.18-soname-fix.patch Please document this patch, and if possible talk to upstream to use correct soname Devel package should require main package: Requires: %{name}%{?_isa} = %{version}-%{release} > %setup -q > %patch0 -p1 -b .soname-fix You could use %autosetup -p1 > %ldconfig_scriptlets I think it's not needed in all supported Fedora releases > %files > ... > %{_libdir}/libzia-%{version}.so.* According to [0], it's better to glob shared libraries this way: %{_libdir}/libzia-%{version}.so.0* [0]: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
