[Bug 1785735] Review Request: convert2rhel - Converting CentOS/OL to RHEL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1785735



--- Comment #3 from Michal Bocek <mbocek@xxxxxxxxxx> ---
Thanks for the review, Neal. 

(In reply to Neal Gompa from comment #2)
> > Release:        1.201912201828Z.master%{?dist}
> 
> This should be simplified down to 1%{?dist}, since it's working from a
> tag-release

Right, I actually have that in the upstream spec:
https://github.com/oamg/convert2rhel/blob/master/packaging/epel/convert2rhel.spec#L9

> > %{python2_sitelib}
> 
> This should be change to: "%{python2_sitelib}/%{name}*"

Thanks, it actually revealed that I was packaging my manpage building script to
/usr/lib/python2.7/site-packages/man/build_manpage.py. I'm removing it now in
the spec.

I've fixed the other comments in https://github.com/oamg/convert2rhel/pull/7
I've also merged this change to the spec:
https://github.com/oamg/convert2rhel/pull/3

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/@oamg/convert2rhel/epel-7-x86_64/01134083-convert2rhel/convert2rhel.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/@oamg/convert2rhel/epel-7-x86_64/01134083-convert2rhel/convert2rhel-0.9-1.201912211524Z.master.el7.src.rpm
EPEL 6 koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39846878
EPEL 7 koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39846899

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux