https://bugzilla.redhat.com/show_bug.cgi?id=1785735 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- First pass review: > %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} > %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} This is unneeded since it's completely unused. > Release: 1.201912201828Z.master%{?dist} This should be simplified down to 1%{?dist}, since it's working from a tag-release > Source0: https://github.com/oamg/%{name}/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz This can be simplified to "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz" > %if ! 0%{?epel:1} > BuildRequires: epel-rpm-macros > %endif This can be simplified just to "BuildRequires: epel-rpm-macros" > Requires: gnupg This doesn't exist on RHEL 6 or RHEL 7. Only "gnupg2" is shipped in RHEL. > %if 0%{?epel} && 0%{?epel} == 6 This can be simplified to "%if 0%{?el6} && 0%{?epel}" > %if 0%{?epel} && 0%{?epel} >= 7 This can be simplified to "%if 0%{?el7} && 0%{?epel}" > %{python2_sitelib} This should be change to: "%{python2_sitelib}/%{name}*" > %{!?_licensedir:%global license %%doc} This isn't needed since you have epel-rpm-macros... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
