https://bugzilla.redhat.com/show_bug.cgi?id=1785495 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity: > Release: 0.1beta%{?dist} This doesn't correspond with https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_more_complex_versioning What about: 0.1.b0? Or even 4.0.0~b0 in version? > https://files.pythonhosted.org/packages/source/p/%{srcname}/%{srcname}-%{version}beta0.tar.gz Upstream calls this b0. The URL with beta0 seems not to work. Maybe us the %{pypi_source} macro? > BuildRequires: python3-devel Add BR for python3-setuptools as that's what the upstream is using to build the package, but you only get it transitively. See the note in python3.spec if you want to know more (starts with '# This is not "API"'). > # Waiting on pwntools to support sphinx 1.7. We no longer have 1.7, but 2.2. This comment is outdated. > # %package doc > # ... Macros in comment. > %{python3_sitelib}/%{srcname}-%{version}b0-py?.?.egg-info This will break with Python 3.10. Use %{python3_version} instead of ?.?. > %{python3_sitelib}/%{srcname}-%{version}b0-py?.?.egg-info > %{python3_sitelib}/pwn > %{python3_sitelib}/pwnlib Add trailing slashes to directories to ensure there are always directories. egg-info has a bad habbit of changing from a directory to a file and breaking the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
