https://bugzilla.redhat.com/show_bug.cgi?id=1782122 --- Comment #4 from Bastien Nocera <bnocera@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #3) > - Group is not used in Fedora Removed. > - Start Release at 1. Also you are missing the dist tag: > > Release: 1.20191211git%{shortcommit}%{?dist} Isn't "1" for the first release? The software here is a 0.1 *pre-release*. Not a version past 0.1. Otherwise I might version it 0.0 instead. > - Request a LICENSE file from upstream Done. https://github.com/flatpak/libportal/issues/7 > - In order to avoid unannounced SONAME bump, we forbid globbing the major > SONAME version, be more specific instead: > > %{_libdir}/libportal.so.0* Done. > - Use a better name for your archive: > > Source: > https://github.com/flatpak/libportal/archive/%{commit}/%{name}- > %{shortcommit}.tar.gz Done. > - Please fix the changelog entry: > > libportal.x86_64: W: incoherent-version-in-changelog 0.1-0.20191211git > ['0.1-0.20191211git7355b1e', '0.1-0.20191211git7355b1e'] > > * Wed Dec 11 2019 Bastien Nocera <bnocera@xxxxxxxxxx> - > 0.1-1.20191211git7355b1e > - Initial release Done. > - I don't see this as necessary: > > Conflicts: %{name} < %{version} Removed. Updated sources at: https://hadess.fedorapeople.org/libportal/libportal-0.1-0.20191211git7355b1e.fc31.src.rpm https://hadess.fedorapeople.org/libportal/libportal.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
