https://bugzilla.redhat.com/show_bug.cgi?id=1775667 --- Comment #3 from Karel Volný <kvolny@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #2) > - License must be installed with %license not %doc: > > %doc AUTHORS README.md > %license LICENSE I see, stupid me :-( > - Release should start with 1: > > Release: 1.20191119git4e1aba67c831r1%{?dist} I've followed https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots the suggested format says "YYYYMMDD<scm><revision>", not "1.YYYYMMDD<scm><revision>" so where does it come from? - should the docs be updated? > Also consider using macros to simplify updating. not sure what do you mean? I've followed https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_hosting_services and wasn't able to come up with something better? > - Include URL: field > > URL: https://bitbucket.org/3dimlab/vpl hm, I totally forgot about it - I would have included it if the template and the packaging guidelines overview wouldn't omit it ... strange, why? - never mind, I'm adding it as it is not in MUST/SHOULD NOT tags list > - Fix line encoding: > > vpl.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/vpl/README.md > > in %prep: > > sed -i "s|\r||g" README.md generally, I tend to ignore line end conversions, but whatever ... :-) thanks for the review I'll upload updated version once will sort out the above questions -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
