[Bug 1780823] Review Request: librinutils-devel - headers-only c11/gnu11 used in Shlomi Fish's C projects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1780823



--- Comment #7 from Shlomi Fish <shlomif@xxxxxxxxxxxxxx> ---
(In reply to Shlomi Fish from comment #5)
> (In reply to Robert-André Mauchin from comment #4)
> >  - Just use:
> > 
> > %package devel
> > 
> >  - Why did you make the headers noarch? The link I sent you explicitly says
> > the opposite:
> > 
> > Do not use noarch
> > 
> > It may be tempting to make the header library package noarch, since the
> > header files themselves are simply text. However, a library should have
> > tests which should be run on all architectures. Also, the install process
> > may modify the installed headers depending on the build architecture. For
> > these reasons, header-only packages must not be marked noarch.
> > 
> > 
> >  - Also why not name it rinutils instead of librinutils? Using lib- prefix
> > is a Debianesque way of doing.
> 
> Fixed here:
> 

Thanks Robert! Should be fixed here (same place):

> * https://www.shlomifish.org/Files/files/code/rinutils.spec
> 
> * https://www.shlomifish.org/Files/files/arcs/rinutils-0.1.4-1.fc32.src.rpm
> 
> Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux