[Bug 1771173] Review Request: xournalpp - Handwriting note-taking software with PDF annotation support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1771173



--- Comment #11 from Luya Tshimbalanga <luya_tfz@xxxxxxxxxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #10)
>  - You're including the data twice by having %{_datadir}/%{name} in the main
> package
> 
> %files -f %{name}.lang
> %license LICENSE
> %doc README.md AUTHORS
> %{_bindir}/xournal-thumbnailer
> %{_bindir}/%{name}
> %{_datadir}/applications/com.github.%{name}.%{name}.desktop
> %{_datadir}/icons/hicolor/scalable/apps/com.github.%{name}.%{name}.svg
> %{_datadir}/icons/hicolor/scalable/mimetypes/*
> %{_datadir}/mime/packages/com.github.%{name}.%{name}.xml
> %exclude %{_datadir}/mimelnk/application/*
> %{_datadir}/thumbnailers/com.github.%{name}.%{name}.thumbnailer
> %{_datadir}/%{name} <----

Good catch. Fixed
> 
> Change it to %dir %{_datadir}/%{name} to just own the directory
> 
> Also the main package should Requires the ui and plugins subpackages for
> them to be installed altogether.

Done.

Updated files
SPECS:
https://copr-be.cloud.fedoraproject.org/results/luya/xournalpp/fedora-rawhide-x86_64/01129170-xournalpp/xournalpp.spec
SRPMS:
https://copr-be.cloud.fedoraproject.org/results/luya/xournalpp/fedora-rawhide-x86_64/01129170-xournalpp/xournalpp-1.0.16-4.fc32.x86_64.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux