https://bugzilla.redhat.com/show_bug.cgi?id=1779403 Jun Aruga <jaruga@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |jaruga@xxxxxxxxxx Flags| |fedora-review+ --- Comment #10 from Jun Aruga <jaruga@xxxxxxxxxx> --- > %exclude %{gem_instdir}/.gitignore > %exclude %{gem_instdir}/.travis.yml Following way could be more maintainable. You see it in other rubygem-*.spec files. You can replace the 2 lines to `%exclude %{gem_instdir}/.*`. ``` -%exclude %{gem_instdir}/.gitignore -%exclude %{gem_instdir}/.travis.yml +%exclude %{gem_instdir}/.* `` I executed `fedora-review` command for this ticket. $ fedora-review -b 1779403 Then seeing `1779403-rubygem-linked-list/review.txt`. > rpmlint okay. ``` rubygem-linked-list.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. ``` * License check: ok * Installing built binary RPMs in mock environment: ok ``` $ mock -i rubygem-linked-list-0.0.13-1.fc32.noarch.rpm rubygem-linked-list-doc-0.0.13-1.fc32.noarch.rpm ``` * Running the installed RPM in mock environment: ok ``` $ mock shell <mock-chroot> sh-5.0# gem list | grep linked-list linked-list (0.0.13) <mock-chroot> sh-5.0# irb irb(main):001:0> require 'linked-list' => true ``` * Scratch build: ok ``` $ koji build --scratch --nowait rawhide rubygem-linked-list-0.0.13-1.fc31.src.rpm https://koji.fedoraproject.org/koji/taskinfo?taskID=39429931 ``` Package is APPROVED. Please fix the `%exclude %{gem_instdir}/.*` issue above when importing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
