[Bug 1779403] Review Request: rubygem-linked-list - Ruby implementation of Doubly Linked List, following some Ruby idioms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1779403



--- Comment #9 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> ---
Thanks for the help, spec file and srpm updated.

(In reply to Vít Ondruch from comment #7)
> Is the `sed -i '/bundler/ s/^/#/' Rakefile` required? Are you using the
> Rakefile anywhere?

I don't believe so, line removed

(In reply to Jun Aruga from comment #8)
> > The `-r test_helper.rb` should not be necessary. Just adding `test` into load path via the `-I` option should be enough.
> 
> You are right, Vit. The `test_helper.rb` is required from all the
> "*_test.rb" file.
> 
> ```
> $ grep -r test_helper test/
> test/list_test.rb:require 'test_helper'
> test/node_test.rb:require 'test_helper'
> test/conversions_test.rb:require 'test_helper'
> ```
> 
> Leigh, could you try without `-r test_helper.rb` option? Then you can remove
> the option.

It works ok without `-r test_helper.rb`

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux