https://bugzilla.redhat.com/show_bug.cgi?id=1779403 --- Comment #2 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> --- Spec and srpm updated (In reply to Vít Ondruch from comment #1) > * Execute the test suite > - The test files are using name_test.rb convention, so you should change > the test command to: > > ~~~ > ruby -Ilib:. -e 'Dir.glob "test/**/*_test.rb", &method(:require)' > ~~~ > The tests fail + ruby -Ilib:. -e 'Dir.glob "test/**/*_test.rb", &method(:require)' Traceback (most recent call last): 6: from -e:1:in `<main>' 5: from -e:1:in `glob' 4: from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require' 3: from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require' 2: from /home/leigh/development/rpmbuild/BUILD/linked-list-0.0.13/usr/share/gems/gems/linked-list-0.0.13/test/conversions_test.rb:1:in `<top (required)>' 1: from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require' /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- test_helper (LoadError) error: Bad exit status from /var/tmp/rpm-tmp.bVoGik (%check) > * Do not ship content of bin/* > - If I am not mistaken, these files are useful just for development > purposes and probably not really useful at all. I would suggest to either > move them to -doc subpackage or remove them entirely. I think that even > upstream should not ship them in the package. bin/* moved to -doc subpackage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
