[Bug 1779403] Review Request: rubygem-linked-list - Ruby implementation of Doubly Linked List, following some Ruby idioms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1779403

Vít Ondruch <vondruch@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vondruch@xxxxxxxxxx



--- Comment #1 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* Execute the test suite
  - The test files are using name_test.rb convention, so you should change the
test command to:

~~~
ruby -Ilib:. -e 'Dir.glob "test/**/*_test.rb", &method(:require)'
~~~

* Do not ship content of bin/*
  - If I am not mistaken, these files are useful just for development purposes
and probably not really useful at all. I would suggest to either move them to
-doc subpackage or remove them entirely. I think that even upstream should not
ship them in the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux