https://bugzilla.redhat.com/show_bug.cgi?id=1778299 --- Comment #6 from Artem <ego.cordatus@xxxxxxxxx> --- > You cannot recommend packages from third-party repositories. Instead you can use reverse rich-deps method from such non-free packages. I didn't recommend, this is just for local self build. I asked about this in rpm chat and answer was it's fine if with %bcond, but need investigate this more. Chromium did the same for example https://src.fedoraproject.org/rpms/chromium/blob/master/f/chromium.spec#_30 Please, this is useful thing if someone want's to build non-free version, but this should "NEVER EVER EVER turn this on in official builds" as it says in Chromium build > Please remove third-party repository name. But why? RPM Fusion is somewhat semi-official? Can we use this for tip for this one who want to made self build locally? > Can be replaced by %{?epoch:%{epoch}:}%{version}-%{release} to avoid future issues with Epoch bumps. Done. > Your freeworld package now will conflict with original and this is not allowed both in Fedora and RPM Fusion. I have no plans YET to package RetroArch for RPM Fusion. Non free version can be grabbed from Flathub anyway. > You must use %license or {_licensedir}/%{name}-assets/COPYING, but not both of them simultaneously. Done. > All sed calls should be replaced by a single one. Done. https://copr-be.cloud.fedoraproject.org/results/atim/retroarch/fedora-31-x86_64/01121819-retroarch/retroarch.spec https://copr-be.cloud.fedoraproject.org/results/atim/retroarch/fedora-31-x86_64/01121819-retroarch/retroarch-1.8.1-7.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
