[Bug 1778299] Review Request: retroarch - Cross-platform, sophisticated frontend for the libretro API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1778299



--- Comment #5 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> ---
> %if %{with freeworld}
> ### Non-free cores
> %endif

You cannot recommend packages from third-party repositories. Instead you can
use reverse rich-deps method from such non-free packages.

> ### Available in RPM Fusion

Please remove third-party repository name.

> %{version}-%{release}

Can be replaced by %{?epoch:%{epoch}:}%{version}-%{release} to avoid future
issues with Epoch bumps.

> %if %{with freeworld}
> %files freeworld
> %else
> %files
> %endif

Your freeworld package now will conflict with original and this is not allowed
both in Fedora and RPM Fusion.

> %license %{_licensedir}/%{name}-assets/COPYING

You must use %license or {_licensedir}/%{name}-assets/COPYING, but not both of
them simultaneously.

> sed -i 

All sed calls should be replaced by a single one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux