Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Shorewall Version 4 - Iptables-based firewall - Review Tracker bug https://bugzilla.redhat.com/show_bug.cgi?id=321731 ------- Additional Comments From jonathan.underwood@xxxxxxxxx 2007-10-07 19:59 EST ------- A remaining question is what to do about Ports.pm. Please see BZ #321711 for a discussion about this. Synopsis: shorewall-perl requires the file: /usr/share/shorewall-perl/Shorewall/Ports.pm Ports.pm is built by buildports.pl which looks at entries in /etc/{services,protocols} and builds Ports.pm accordingly. /etc/{services,protocols} are part of the setup package. The current strategy in the spec file is that Ports.pm is created at package build time by Build:requiring the setup package. However, the following issues then arise: A) What if the user has modified locally /etc/{services,protocols} B) What if another package modifies /etc/{services,protocols} on package installation (Ville recalled that the LTSP stuff might do this) The only way around that would be to create Ports.pm on package installation. This could be done in %post, and indeed the upstream sample spec does just that. But, Ville also points out that creating files under /usr on package installation fails if /usr is read-only (but then again, so will package installation). So, then we'd have to do the building of Ports.pm under /var/lib/shorewall-perl, and package a symlink there from /usr/share/shorewall-perl. This is all do-able, but I can't help preferring the KISS approach of generating Ports.pm at package build time using /etc/{services,protocols} from the setup package. For case B above I would argue that the LTSP packager should have his changes to /etc/{services,protocols} incoorporated into the setup package files. ... Thoughts? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review