Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Shorewall Version 4 - Iptables-based firewall - Review Tracker bug https://bugzilla.redhat.com/show_bug.cgi?id=321731 ------- Additional Comments From jonathan.underwood@xxxxxxxxx 2007-10-07 19:48 EST ------- Spec URL: http://jgu.fedorapeople.org/shorewall.spec SRPM URL: http://jgu.fedorapeople.org/shorewall-4.0.4-1.fc7.src.rpm This is the combined tarball package. Plus it now contains the shorewall-lite functionality. The main package (shorewall) simply Requires the sub-packages shorewall-common, shorewall-perl and shorewall-shell. This is the pragmatic approach, aimed at not breaking existing installations that require the legacy shell compiler. The clued up user could install only shorewall-common and shorewall-perl or shorewall-shell if she only wanted one compiler. There is also a sub-package for shorewall-lite. Running rpmlint on the subpackages: $ rpmlint ../RPMS/noarch/shorewall-common-4.0.4-1.fc7.noarch.rpm shorewall-common.noarch: W: service-default-enabled /etc/rc.d/init.d/shorewall --> Bogus, as the Defaul-Start entry is empty shorewall-common.noarch: E: subsys-not-used /etc/rc.d/init.d/shorewall --> This is ok, as although the init file doesn't create a lockfile, shorewall itself does. shorewall-common.noarch: W: incoherent-init-script-name shorewall --> Irrelevant $ rpmlint ../RPMS/noarch/shorewall-perl-4.0.4-1.fc7.noarch.rpm No warnings or errors $ rpmlint ../RPMS/noarch/shorewall-shell-4.0.4-1.fc7.noarch.rpm shorewall-shell.noarch: E: non-executable-script /usr/share/shorewall-shell/prog.header 0644 --> prog.header has a hash-bang at the top, but isn't executable as this file is simply a template for shorewall to use when generating a shell script, and so it shouldn't be executeable. $ rpmlint ../RPMS/noarch/shorewall-lite-4.0.4-1.fc7.noarch.rpm shorewall-lite.noarch: W: non-conffile-in-etc /etc/shorewall-lite/Makefile --> A weird one. that Makefile is used by shorewall-lite and is intentionally put in /etc by upstream... not sure waht to do about this really. shorewall-lite.noarch: W: service-default-enabled /etc/rc.d/init.d/shorewall-lite --> bogus again - Default-Start is empty, Default-Stop has all runlevels. shorewall-lite.noarch: E: subsys-not-used /etc/rc.d/init.d/shorewall-lite --> Again, shorewall-lite handles lock file creation itself, there's no need for the init script to create one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review