https://bugzilla.redhat.com/show_bug.cgi?id=1774713 --- Comment #11 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> --- The Long Version Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - [!] [kashyapc] Rich, I don't see a %license macro in the RPM Spec; looks like it's mandatory. - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/virt-v2v See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - [x] [kashyapc] The above is okay; this is a conscious choice by the packager to disentangle the 'virt-v2v' tool from libguesfs package into a standalone package. ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed - [kashyapc] Gnulib is built from source: $> find . -name gnulib ./rpms-unpacked/virt-v2v-debugsource-1.41.8-2.fc32.x86_64.rpm/usr/src/debug/virt-v2v-1.41.8-2.fc32.x86_64/gnulib ./upstream-unpacked/Source0/virt-v2v-1.41.8/gnulib [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [-]: Header files in -devel subpackage, if present. - [kashyapc] No -devel package. [x]: Package does not contain any libtool archives (.la) - [kashyapc] The spec deletes ""libtool crap" [-]: Rpath absent or only used for internal libs. - [kashyapc] Not relevant. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. - [kashyapc] Package is GPLv2+ [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. - [kashyapc] The above is fine -- License file (COPYING) is included as an upstream patch, instead of respinning the tarball. [!]: License file installed when any subpackage combination is installed. - [kashyapc] Although license file isn't shipped when you [x ... ?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/bash- completion/completions(bodhi-client, subversion, rpmdevtools, git- core, flatpak, filesystem, libqmi, cowsay, devscripts, fd-find, ndctl, zeitgeist, falkon, cpu-x, lightdm, GMT-common, coccinelle-bash- completion, why3, zola, clufter-cli, xss-lock, ripgrep, swayidle, mercurial, vagrant, nitrokey-app, tig, the_silver_searcher, exa, zypper, swaylock, dconf-editor, devscripts-checkbashisms, fedmod, python3-pip, cmake-data, bash-completion, opensc, firejail, yadifa, driverctl, libmbim, dnf, gpaste, rtags, python3-trezor, tracker, firewalld, gtatool, pbuilder, sway, pdfgrep, libappstream-glib, python3-catkin_tools, rkt, eg, fedpkg, lastpass-cli, rpmlint, lxi- tools, toolbox, docopt, bubblewrap, skopeo, restic, yadifa-tools, maven, plowshare, gammu, task, ldc, tio, calibre, chocolate-doom, kmod, reprepro, datamash, minipro, breezy, git-annex, calf, python- django-bash-completion, exercism, libguestfs-bash-completion, etckeeper, buildah, nnn, glib2, ModemManager, clevis, beaker-client, stratis-cli, source-highlight, licensecheck, docker-compose, lxc, nbdkit-bash-completion, mtr, ethtool, unar, kompose, skim) - [kashyapc] I _think_ this is fine -- it is listing the 'bash-completion' package; needs double-confirmation. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package - [kashyapc] No -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). - [kashyapc] The 'gpgverify' macro will be used [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. - [x] [kashyapc] Package _does_ exclude i686 -- but with good rationale (included in the spec): as Linux kernel itself isn't built anymore for i686, and this package has a fundamental dependency on kernel. [!]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 1 files. - [kashyapc] Looks like we need to split out the file? [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in virt-v2v-bash-completion , virt-v2v-man-pages-ja , virt-v2v-man-pages- uk - [kashyapc] Rich said on IRC he's going put the %{?_isa} macro for subpackages, "although that's not really needed for OCaml programs" [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. - [kashyapc] Rich is going to fix this. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. - [kashyapc] Soe [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: virt-v2v-1.41.8-2.fc32.x86_64.rpm virt-v2v-bash-completion-1.41.8-2.fc32.noarch.rpm virt-v2v-man-pages-ja-1.41.8-2.fc32.noarch.rpm virt-v2v-man-pages-uk-1.41.8-2.fc32.noarch.rpm virt-v2v-debuginfo-1.41.8-2.fc32.x86_64.rpm virt-v2v-debugsource-1.41.8-2.fc32.x86_64.rpm virt-v2v-1.41.8-2.fc32.src.rpm virt-v2v.x86_64: W: spelling-error %description -l en_US hypervisors -> hyper visors, hyper-visors, supervisors virt-v2v.x86_64: W: spelling-error %description -l en_US oVirt -> overt virt-v2v.x86_64: W: spelling-error %description -l en_US bootable -> bookable, boo table, boo-table virt-v2v.x86_64: W: spelling-error %description -l en_US virtio -> virtuoso virt-v2v.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-v2v virt-v2v.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-v2v-copy-to-local virt-v2v.x86_64: W: dangling-symlink /usr/share/virt-tools/rhsrvany.exe /usr/i686-w64-mingw32/sys-root/mingw/bin/rhsrvany.exe virt-v2v-bash-completion.noarch: W: no-documentation virt-v2v.src: W: spelling-error %description -l en_US hypervisors -> hyper visors, hyper-visors, supervisors virt-v2v.src: W: spelling-error %description -l en_US oVirt -> overt virt-v2v.src: W: spelling-error %description -l en_US bootable -> bookable, boo table, boo-table virt-v2v.src: W: spelling-error %description -l en_US virtio -> virtuoso 7 packages and 0 specfiles checked; 2 errors, 10 warnings. Rpmlint (debuginfo) ------------------- Checking: virt-v2v-debuginfo-1.41.8-2.fc32.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). virt-v2v.x86_64: W: spelling-error %description -l en_US hypervisors -> hyper visors, hyper-visors, supervisors virt-v2v.x86_64: W: spelling-error %description -l en_US oVirt -> overt virt-v2v.x86_64: W: spelling-error %description -l en_US bootable -> bookable, boo table, boo-table virt-v2v.x86_64: W: spelling-error %description -l en_US virtio -> virtuoso virt-v2v.x86_64: W: invalid-url URL: https://github.com/libguestfs/virt-v2v <urlopen error [Errno -2] Name or service not known> virt-v2v.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-v2v virt-v2v.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-v2v-copy-to-local virt-v2v.x86_64: W: dangling-symlink /usr/share/virt-tools/rhsrvany.exe /usr/i686-w64-mingw32/sys-root/mingw/bin/rhsrvany.exe virt-v2v-debugsource.x86_64: W: invalid-url URL: https://github.com/libguestfs/virt-v2v <urlopen error [Errno -2] Name or service not known> virt-v2v-man-pages-uk.noarch: W: invalid-url URL: https://github.com/libguestfs/virt-v2v <urlopen error [Errno -2] Name or service not known> virt-v2v-bash-completion.noarch: W: invalid-url URL: https://github.com/libguestfs/virt-v2v <urlopen error [Errno -2] Name or service not known> virt-v2v-bash-completion.noarch: W: no-documentation virt-v2v-man-pages-ja.noarch: W: invalid-url URL: https://github.com/libguestfs/virt-v2v <urlopen error [Errno -2] Name or service not known> virt-v2v-debuginfo.x86_64: W: invalid-url URL: https://github.com/libguestfs/virt-v2v <urlopen error [Errno -2] Name or service not known> 6 packages and 0 specfiles checked; 2 errors, 12 warnings. Source checksums ---------------- http://download.libguestfs.org/virt-v2v/1.41-development/virt-v2v-1.41.8.tar.gz.sig : CHECKSUM(SHA256) this package : b3a08e729cc9af2960f1a4928b8b3be63731d22c978dae7d12292263e0d2b3f6 CHECKSUM(SHA256) upstream package : b3a08e729cc9af2960f1a4928b8b3be63731d22c978dae7d12292263e0d2b3f6 http://download.libguestfs.org/virt-v2v/1.41-development/virt-v2v-1.41.8.tar.gz : CHECKSUM(SHA256) this package : a42e1b69a29f20ad0362fb517cba9eacca86266bcd9dccbc50830299291a09ac CHECKSUM(SHA256) upstream package : a42e1b69a29f20ad0362fb517cba9eacca86266bcd9dccbc50830299291a09ac [...] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
