https://bugzilla.redhat.com/show_bug.cgi?id=1774713 --- Comment #10 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> --- ====== Review ====== (NB: My comments in the longer review are prefixed with [kashyapc].) tl;dr ===== Needs Fixing ~~~~~~~~~~~~ (1) '%license' macro is missing. (2) License file is not included when you install debuginfo (or any other sub-packages). (3) The many packages listed under "Dirs in package are owned also by: [...]" are all related to 'bash-completion'. I _think_ that's benign; Rich, please double-confirm; I marked the item as [x ... ?]. Rich has raised it on 'fedora-devel': https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx/thread/H572VSN6O5H32SKIDR5ZIKU5DFN76SBD/ (4) Seems like documentation size is 30720 bytes in 1 files. Needs a separate -doc subpackage? (5) Missing %{?_isa} macro for subpackages -- Rich said on IRC he's going to put it in, "although that's not really needed for OCaml programs" (6) Need to use the '%{gpgverify}' macro (instead of `gpgv2` in the %prep section). (7) Strangely, `rpmlint` further below complaints of an "invalid URL", but it works for me: invalid-url URL: https://github.com/libguestfs/virt-v2v <urlopen error [Errno -2] Name or service not known> Observations ~~~~~~~~~~~~ (*) Question asked/answered on IRC: "What if a user has 'virt-v2v' from libguestfs, and updates her Fedora host which brings 'virt-v2v' as its _own_ package?" Answer (from Rich): "Yeah, hopefully; I'm only proposing to make this change in Rawhide. Note the binary package isn't being renamed, it's just produced by a different source" (*) The "ExcludeArch" for i686 is justifiable; hence I gave the [x]. Comment inline. (*) `rpmlint` marks the below two as ERRORs: virt-v2v.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-v2v virt-v2v.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/virt-v2v-copy-to-local Rich confirmed on IRC that the above is a false positive: "I guess because the OCaml Unix module is statically linked in, and that has bindings for every POSIX call" Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1396563 -- rpmlint often reports false positives missing-call-to-chdir-with-chroot on x86_64 * * * -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
