https://bugzilla.redhat.com/show_bug.cgi?id=1776669 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |mhroncok@xxxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review? --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Quick eyes only check: 1. please add %python_provide: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_python_provide_macro 2. you can use %pypi_source in Source0: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi 3. Obsoletes: pycdio < 2.0.0-5 -- maybe it should be < 2.0.0-6? I see 2.0.0-5.fc31 in Fedora 31 4. Requires: python3 is redundant 5. %{python3_sitearch}/* should not be used https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_files_to_include Will run automated checks on the next spec iteration. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
