https://bugzilla.redhat.com/show_bug.cgi?id=1776509 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-256: e476bd1739e68f418617c308c3c3cf742de6a595c23bbac2c270e14159f73122) is original. Ok. Summary verified from lib/Test2/Tools/Explain.pm. Ok TODO: Rephrase the summary from "Perl's Test2 framework" to "Perl Test2 framework" or "Test2 framework of Perl". In my humble English knowledge possessive nouns cannot be used for languages. Description: Verified from lib/Test2/Tools/Explain.pm. Ok. License verified from lib/Test2/Tools/Explain.pm. Ok. TODO: Build-require 'perl(:VERSION) >= 5.8.1' (Makefile.PL:1). All tests pass. Ok. $ rpmlint perl-Test2-Tools-Explain.spec ../SRPMS/perl-Test2-Tools-Explain-0.02-1.fc32.src.rpm ../RPMS/noarch/perl-Test2-Tools-Explain-0.02-1.fc32.noarch.rpm sh: /usr/bin/python2: No such file or directory 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Test2-Tools-Explain-0.02-1.fc32.noarch.rpm drwxr-xr-x 2 root root 0 Nov 26 09:26 /usr/share/doc/perl-Test2-Tools-Explain -rw-r--r-- 1 root root 210 Oct 4 2016 /usr/share/doc/perl-Test2-Tools-Explain/Changes -rw-r--r-- 1 root root 441 Oct 4 2016 /usr/share/doc/perl-Test2-Tools-Explain/README.md -rw-r--r-- 1 root root 2989 Nov 26 09:26 /usr/share/man/man3/Test2::Tools::Explain.3pm.gz drwxr-xr-x 2 root root 0 Nov 26 09:26 /usr/share/perl5/vendor_perl/Test2 drwxr-xr-x 2 root root 0 Nov 26 09:26 /usr/share/perl5/vendor_perl/Test2/Tools -rw-r--r-- 1 root root 4358 Oct 4 2016 /usr/share/perl5/vendor_perl/Test2/Tools/Explain.pm File permissions and layout is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Test2-Tools-Explain-0.02-1.fc32.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.1) 1 perl(:VERSION) >= 5.8.1 1 perl(Data::Dumper) 1 perl(Exporter) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Test2-Tools-Explain-0.02-1.fc32.noarch.rpm | sort -f | uniq -c 1 perl(Test2::Tools::Explain) = 0.02 1 perl-Test2-Tools-Explain = 0.02-1.fc32 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Test2-Tools-Explain-0.02-1.fc32.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in F32 (https://koji.fedoraproject.org/koji/taskinfo?taskID=39353916). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please consider fixing the 'TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
