https://bugzilla.redhat.com/show_bug.cgi?id=1775445 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |python-JuPyMake - Python |python-jupymake - Python |wrapper for the polymake |wrapper for the polymake |shell |shell --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > Please change name to lowercase. Done. > Issues: > ======= > - Package contains BR: python2-devel or python3-devel > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_dependencies > says > > Packages building for Python 3 will need BuildRequires: python3-devel. Ha, that's funny. We have dueling packaging guidelines. The spec file contains: BuildRequires: pkgconfig(python3) because of the packaging guideline that says you have to use the pkgconfig(foo) variant when it is available ... which it is with python3-devel. So I think the python guidelines will have to be updated to say that you must BR pkgconfig(python2) or pkgconfig(python3). > - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files > Note: Package contains %{pythonX_site(lib|arch)}/* in %files > See: https://pagure.io/packaging-committee/issue/782 > Yep, please switch to a more specific pattern. Oops, that was an oversight. I generated the spec file with rpmdev-newspec, which put that glob there. I saw it and intended to make it more specific, but forgot. New URLs: Spec URL: https://jjames.fedorapeople.org/python-jupymake/python-jupymake.spec SRPM URL: https://jjames.fedorapeople.org/python-jupymake/python-jupymake-0.9-1.20190509.031cc3a.fc32.src.rpm RPMLINTRC URL: https://jjames.fedorapeople.org/python-jupymake/python-jupymake.rpmlintrc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
