https://bugzilla.redhat.com/show_bug.cgi?id=1767918 --- Comment #3 from Tony Asleson <tasleson@xxxxxxxxxx> --- (In reply to Elliott Sales de Andrade from comment #2) > Group is not used in Fedora. Done > Why do you need a separate targetd.yaml when it's in the upstream tarball? We don't and they appear to be identical, removed. > It's preferable to place (Build)Requires on separate lines. Done > You should not manually compress man pages. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages Done > It is not permitted to glob the %{python3_sitelib} directory. > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_files_to_include Done > LICENSE should be marked as %license, not %doc. Done > I don't think you need BuildRequires: systemd, but systemd-rpm-macros. > https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/ Done > Runtime Python requirements really should be automatically detected, but the > setup.py does not list them. You should report this upstream. Reported: https://github.com/open-iscsi/targetd/issues/34 Thanks for the review. Updated spec file = https://tasleson.fedorapeople.org/targetd/targetd.spec.1 diff --git a/targetd.spec b/targetd.spec index cb1a84e..ccd3f62 100644 --- a/targetd.spec +++ b/targetd.spec @@ -1,15 +1,14 @@ Name: targetd License: GPLv3 -Group: System Environment/Libraries Summary: Service to make storage remotely configurable Version: 0.8.9 Release: 1%{?dist} URL: https://github.com/open-iscsi/targetd Source: https://github.com/open-iscsi/targetd/archive/v%{version}/targetd-%{version}.tar.gz Source1: targetd.service -Source2: targetd.yaml BuildArch: noarch -BuildRequires: systemd, python3-devel +BuildRequires: systemd-rpm-macros +BuildRequires: python3-devel Requires: python3-PyYAML python3-setproctitle python3-rtslib target-restore Requires: nfs-utils, btrfs-progs, python3-blockdev, libblockdev-lvm Requires(post): systemd @@ -28,15 +27,14 @@ those volumes over iSCSI. %build %{__python3} setup.py build -gzip --stdout targetd.8 > targetd.8.gz %install mkdir -p %{buildroot}%{_mandir}/man8/ mkdir -p %{buildroot}%{_unitdir} mkdir -p %{buildroot}%{_sysconfdir}/target/ install -m 644 %{SOURCE1} %{buildroot}%{_unitdir}/targetd.service -install -m 644 %{SOURCE2} %{buildroot}%{_sysconfdir}/target/targetd.yaml -install -m 644 targetd.8.gz %{buildroot}%{_mandir}/man8/ +install -m 644 targetd.yaml %{buildroot}%{_sysconfdir}/target/targetd.yaml +install -m 644 targetd.8 %{buildroot}%{_mandir}/man8/ %{__python3} setup.py install --skip-build --root %{buildroot} %post @@ -51,8 +49,10 @@ install -m 644 targetd.8.gz %{buildroot}%{_mandir}/man8/ %files %{_bindir}/targetd %{_unitdir}/targetd.service -%{python3_sitelib}/* -%doc LICENSE README.md API.md client +%{python3_sitelib}/targetd/ +%{python3_sitelib}/*.egg-info +%license LICENSE +%doc README.md API.md client %{_mandir}/man8/targetd.8.gz %config(noreplace) %{_sysconfdir}/target/targetd.yaml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
