https://bugzilla.redhat.com/show_bug.cgi?id=1767918 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@xxxxxxxxx --- Comment #2 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> --- Group is not used in Fedora. Why do you need a separate targetd.yaml when it's in the upstream tarball? It's preferable to place (Build)Requires on separate lines. You should not manually compress man pages. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages It is not permitted to glob the %{python3_sitelib} directory. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_files_to_include LICENSE should be marked as %license, not %doc. I don't think you need BuildRequires: systemd, but systemd-rpm-macros. https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/ Runtime Python requirements really should be automatically detected, but the setup.py does not list them. You should report this upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
