Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: safekeep - simple, centralized configuration for rdiff-backup https://bugzilla.redhat.com/show_bug.cgi?id=241553 ------- Additional Comments From jspaleta@xxxxxxxxx 2007-10-05 18:03 EST ------- (In reply to comment #23) > See below - License (GPLv2+) > See below- License field in spec matches > See below- License file included in package > Issues: > > 1. What is the license here? > The LICENSE file in the source says GPLv2.1 > The spec has GPLv2+ > The scripts themselves don't have any mention of a license. > The web site says GPL > http://safekeep.sourceforge.net/license.shtml > > Ideally can you get upstream to say if it's GPLv2 only, GPLv2+, or GPL+? > A comment in the scripts themselves would be good. > Also matching up so that all the above say the same thing would be good. > > 2. This is 1.0.2, but the website seems to have 1.0.1 as latest. > Is this a preview release or they just haven't updated the web site yet? The website itself needs to be updated. But sf.net project space has 1.0.2 listed as the most current release. http://sourceforge.net/project/showfiles.php?group_id=185128 > 4. Perhaps you could include a README.fedora in the client subpackage > explaining why it's currently empty? Easily done. I'll get to it tomorrow. > 5. The client subpackage has: > Requires: openssh-server > Requires: coreutils > Requires: util-linux > > Are those really required? Why? okay.. the way this works is that the safekeep server process pulls updates from clients over ssh. The server sets up special ssh keys on the client specifically for this so the rdiff-backup process can be automated using passphrase-less ssh keys constrained to run only the rdiff-backup commands. So the client needs a running ssh server. I believe coreutils and util-linux are needed for helper commands that allow the server to interact with the client to setup the specialized ssh keys. I can dig into the code tomorrow and confirm the specifics of that. -jef -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review