Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1 https://bugzilla.redhat.com/show_bug.cgi?id=247406 ------- Additional Comments From s.adam@xxxxxxxxxxxx 2007-10-05 18:03 EST ------- If you don't mind I'll take it :) I got a 404 error with the SRPM above, I'll use this instead: http://devel.foss.org.my/~kagesenshi/repo/private/testing/libcompizconfig/libcompizconfig-0.5.2-0.1.fc7.src.rpm Let me know if I should be using another SRPM. + source files match upstream + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. - license field matches the actual license. "GPL" is no longer a vlid license. Please specify the version - See http://fedoraproject.org/wiki/Licensing for more info. + license is open source-compatible, GPL License text included in package. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package installs properly + debuginfo package looks complete. + rpmlint is silent. It isn't "silent", but the errors can be ignored. + no shared libraries are added to the regular linker search paths. - owns the directories it creates. It should own %{_datadir}/compizconfig and %{_libdir}/compizconfig + doesn't own any directories it shouldn't. + no duplicates in %files. + documentation is small, so no -docs subpackage is necessary. + headers, pkgconfig files are in -devel package + no .la files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review