https://bugzilla.redhat.com/show_bug.cgi?id=1755870 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- > TODO: There is no link from a page on the URL location to Source0. Maybe you should use Source0 from Github releases, or change URL to CPAN to be consistent. -URL: https://github.com/karupanerura/Test-Deep-Fuzzy +URL: https://metacpan.org/pod/Test::Deep::Fuzzy We usually use a link to a CPAN release page <https://metacpan.org/release/Test-Deep-Fuzzy>. Not to a documentation of a module as you used. But this is distribution contain only one documented module so it does not matter much. Ok. >TODO: Do not version perl-interpreter (perl-interpreter >= 5.008001). Use 'perl(:VERSION) >= 5.8.1' for that purpose. perl-interpreter has an epoch number and the comparison does not work. -BuildRequires: perl-interpreter >= 5.008001 +BuildRequires: perl(:VERSION) >= 5.8.1 FIX: Build-require 'perl-interpreter' (perl-Test-Deep-Fuzzy.spec:33). > FIX: Do not build-require 'perl(Module::Build)'. It's not used anywhere. -BuildRequires: perl(Module::Build) Ok. $ rpmlint perl-Test-Deep-Fuzzy.spec ../SRPMS/perl-Test-Deep-Fuzzy-0.01-2.fc32.src.rpm ../RPMS/noarch/perl-Test-Deep-Fuzzy-0.01-2.fc32.noarch.rpm sh: /usr/bin/python2: No such file or directory 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Test-Deep-Fuzzy-0.01-2.fc32.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.0) 1 perl(:VERSION) >= 5.8.1 1 perl(B) 1 perl(Exporter) >= 5.57 1 perl(Math::Round) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Test::Deep::Cmp) 1 perl(Test::Deep::Fuzzy::Number) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Test-Deep-Fuzzy-0.01-2.fc32.noarch.rpm | sort -f | uniq -c 1 perl(Test::Deep::Fuzzy) = 0.01 1 perl(Test::Deep::Fuzzy::Number) 1 perl-Test-Deep-Fuzzy = 0.01-2.fc32 Binary provides are Ok. $ resolvedeps f32-build ../RPMS/noarch/perl-Test-Deep-Fuzzy-0.01-2.fc32.noarch.rpm Binary dependencies are resolvable. Ok. Please correct the 'FIX' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
