[Bug 1754957] Review Request: lua-luv - lua bindings for libuv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1754957



--- Comment #5 from Aron Griffis <aron@xxxxxxxxxxxxxxx> ---
I realized I'm overthinking this. The OpenSUSE builds seem to work fine
with the -DBUILD_MODULE=ON approach. On Tumbleweed I see (leaving out the
uninteresting parts)

    # rpm -ql lua51-luv-1.30.1-1.1.x86_64
    /usr/lib64/lua/5.1/luv.so

    # rpm -ql lua51-luv-devel
    /usr/include/lua5.1/luv/lhandle.h
    /usr/include/lua5.1/luv/lreq.h
    /usr/include/lua5.1/luv/lthreadpool.h
    /usr/include/lua5.1/luv/luv.h
    /usr/include/lua5.1/luv/util.h

and there is no pkgconfig file. So we shouldn't need one on Fedora either,
and that means your rpm is fine. Sorry for the fuss, Andreas. 🤦

For the neovim 0.4.2 build, it seems we just need to indicate where to find
libluv. This works in my experiments:

    %if %{with luajit}
    %global luaver 5.1
    %else
    %global luaver 5.3
    %endif

    -DLIBLUV_INCLUDE_DIR=%{_includedir}/lua-%{luaver} \
    -DLIBLUV_LIBRARY=%{_libdir}/lua/%{luaver}/luv.so \

That assumes that the proper version of libvterm is available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux