https://bugzilla.redhat.com/show_bug.cgi?id=1754957 --- Comment #4 from Aron Griffis <aron@xxxxxxxxxxxxxxx> --- Andreas, I tried to review this but it's been a painful number of hours and I still don't have anything working. Sure it builds into an rpm, but does that rpm work for building neovim? Not that I've been able to accomplish. When neovim builds, it looks for the pkgconfig file which isn't included in this rpm. Building the libluv.pc file depends on -DBUILD_SHARED_LIBS=ON which is mutually exclusive with -DBUILD_MODULE=ON. However even if you build the pc file, everything inside it will be wrong, so that needs to be patched/replaced also. So anyway, here are my notes, in case you want to take another run at it: 1. -DBUILD_MODULE=ON and -DBUILD_SHARED_LIBS=ON are mutually exclusive. The former builds bare luv.so and the latter builds a versioned libluv.so with all the symlinks and the pkgconfig file. However the only place BUILD_SHARED_LIBS is referenced is in an "else" section for BUILD_MODULE, so if you want that, you have to use -DBUILD_MODULE=OFF -DBUILD_SHARED_LIBS=ON 2. On Debian, they completely ignore the CMakeLists.txt and build the entire thing with their own debhelper-powered formula. They also generate their own pkgconfig file without referring to the one included in the source. The upside is that everything gets installed consistently. One thing to note is that they effectively build the equivalent of -DBUILD_SHARED_LIBS (versioned dir) and then they symlink from that to luv.so for Lua to load. 3. I'm not sure, but it seems like this lib might link directly to the underlying interpreter library as well, which means that the lua-5.1 version of the build might NOT be the same as the luajit version. I wish I had better news for you :-( -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
