[Bug 1754144] Review Request: python-cma - Co-variance Matrix Adaptation Evolution Strategy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1754144



--- Comment #2 from Christoph Junghans <junghans@xxxxxxxxx> ---
(In reply to Miro Hrončok from comment #1)
> > %global sum Co-variance Matrix Adaptation Evolution Strategy
> 
> You can just set:
> 
> Summary: Co-variance Matrix Adaptation Evolution Strategy
> 
> and later use:
> 
> Summary: %{summary}
Cool, didn't know that would work, changed.

> > BuildRequires: python3-devel
> 
> The package uses setuptools (see setup.py), please also BR
> python3-setuptools.
Added.

> > Requires: python3-numpy
> 
> Does the automatic dependency generator not work?
Didn't know there was an automatic dep generator, so dropped

> > chmod +x %{buildroot}%{python3_sitelib}/cma/{bbobbenchmarks.py,purecma.py,test.py}
> 
> Why do those files need to be executables? Why do they have shebangs?
Good point, I looked that there scripts again and all of them can be used with
e.g. "python -m cma.test", so dropping the shebang should be fine.

> > %{python3_sitelib}/%{srcname}
> > %{python3_sitelib}/%{srcname}-%{version}-*.egg-info
> 
> It's more explicit if you put a leading slash, such as:
> 
> %{python3_sitelib}/%{srcname}/
> %{python3_sitelib}/%{srcname}-%{version}-*.egg-info/
Changed.

Spec URL: https://junghans.fedorapeople.org/python-cma.spec
SRPM URL: https://junghans.fedorapeople.org/python-cma-2.7.0-2.fc30.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux