[Bug 1754144] Review Request: python-cma - Co-variance Matrix Adaptation Evolution Strategy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1754144

Miro Hrončok <mhroncok@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mhroncok@xxxxxxxxxx



--- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
> %global sum Co-variance Matrix Adaptation Evolution Strategy

You can just set:

Summary: Co-variance Matrix Adaptation Evolution Strategy

and later use:

Summary: %{summary}

---


> BuildRequires: python3-devel

The package uses setuptools (see setup.py), please also BR python3-setuptools.

---


> Requires: python3-numpy

Does the automatic dependency generator not work?

---


> chmod +x %{buildroot}%{python3_sitelib}/cma/{bbobbenchmarks.py,purecma.py,test.py}

Why do those files need to be executables? Why do they have shebangs?

---


> %{python3_sitelib}/%{srcname}
> %{python3_sitelib}/%{srcname}-%{version}-*.egg-info

It's more explicit if you put a leading slash, such as:

%{python3_sitelib}/%{srcname}/
%{python3_sitelib}/%{srcname}-%{version}-*.egg-info/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux