https://bugzilla.redhat.com/show_bug.cgi?id=1751409 --- Comment #6 from Christoph Junghans <junghans@xxxxxxxxx> --- (In reply to Dave Love from comment #5) > I was about to take this, as requested, but see I'm too late. I'll comment > anyhow as someone who might actually build against it. Good point, thanks for your inputs. > My main concern with it is versioning. Why is it using a snapshot, not a > release version? > Then, the soname should have a semantic version, not the "release" version. Yeah, I wanted to build a snapshot before the actual 3.0 release to see if everything works, kokkos is usually bundled with packages, so un bundling it might give us some surprises. And the library aren't abi-compatible between version see https://github.com/kokkos/kokkos/pull/2291#issuecomment-529268933, so having the full version should be ok. > It should use %ldconfig_scriptlets for use in EPEL (though I don't know if > that's just EPEL7), and I'd have thought it should ship docs. I am not planning to package it for EPEL7, EPEL8 yes, but not 7. If you want to take a shot at it, please let me know. > Given that it's a performance library, with support for "aggressive > vectorization", would it not benefit from better compilation options, and > use of devtoolset-8 for el7? Possibly also target-specific builds. (I > don't actually know where the performance comes from.) Optimization are on my To-Do list, so stay tuned. > Can you not use the ROCm option to provide GPU support for Fedora? I don't > know if there's a good reason ROCm isn't in EPEL, where it would be more > useful. I was planning to compile it with OpenMP offload for the device parallelization in the next iteration. > I haven't had a chance to see how a separate build would integrate with > possible packaging of Trilinos. Is that clear? I haven't had a chance to > re-examine the older Trilinos packaging I did. I believe there is some work going on to allow Trilinos to be compiled with external kokkos. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
