https://bugzilla.redhat.com/show_bug.cgi?id=1751409 Dave Love <dave.love@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dave.love@xxxxxxxxxxxxxxxx --- Comment #5 from Dave Love <dave.love@xxxxxxxxxxxxxxxx> --- I was about to take this, as requested, but see I'm too late. I'll comment anyhow as someone who might actually build against it. My main concern with it is versioning. Why is it using a snapshot, not a release version? Then, the soname should have a semantic version, not the "release" version. It should use %ldconfig_scriptlets for use in EPEL (though I don't know if that's just EPEL7), and I'd have thought it should ship docs. Given that it's a performance library, with support for "aggressive vectorization", would it not benefit from better compilation options, and use of devtoolset-8 for el7? Possibly also target-specific builds. (I don't actually know where the performance comes from.) Can you not use the ROCm option to provide GPU support for Fedora? I don't know if there's a good reason ROCm isn't in EPEL, where it would be more useful. I haven't had a chance to see how a separate build would integrate with possible packaging of Trilinos. Is that clear? I haven't had a chance to re-examine the older Trilinos packaging I did. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
